Fix spaceSelectsMatch causing error (fixes #495)
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobwhitelock
added a commit
to bobwhitelock/todotxt-ui
that referenced
this pull request
Jul 28, 2020
An error on autocomplete can still occur when `spaceSelectsMatch` is enabled, but this doesn't actually appear to break anything; therefore enabling this option now. zurb/tribute#529 should fix this error.
With `spaceSelectsMatch` enabled, an error `Uncaught TypeError: Cannot read property '0' of undefined` is sometimes given when attempting to autocomplete with any of space, tab, or enter. The cause appears to be that with this option enabled, sometimes this code path intended to handle KeyboardEvents will be entered again after handling a KeyboardEvent with another type of event (CustomEvent); this then later causes this error as `this.current.filteredItems` is now `undefined`, as the original KeyboardEvent has already been handled. Checking whether the event looks like a KeyboardEvent, and returning early if it doesn't, appears to resolve this.
bobwhitelock
force-pushed
the
fix-spaceSelectsMatch-causing-error
branch
from
b523c1f to
3d0e9f7
Compare
|
Just ran into the same error on another project - I've rebased on the latest |
|
Merged! Thank you. |
|
Thank you! 🎉 |
tiagomagnusss
pushed a commit
to promoteinternational/tribute
that referenced
this pull request
Nov 17, 2021
With `spaceSelectsMatch` enabled, an error `Uncaught TypeError: Cannot read property '0' of undefined` is sometimes given when attempting to autocomplete with any of space, tab, or enter. The cause appears to be that with this option enabled, sometimes this code path intended to handle KeyboardEvents will be entered again after handling a KeyboardEvent with another type of event (CustomEvent); this then later causes this error as `this.current.filteredItems` is now `undefined`, as the original KeyboardEvent has already been handled. Checking whether the event looks like a KeyboardEvent, and returning early if it doesn't, appears to resolve this. (cherry picked from commit 046ae53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
spaceSelectsMatchenabled, an errorUncaught TypeError: Cannot read property '0' of undefinedis sometimes given when attempting to autocomplete with any of space, tab, or enter.The cause appears to be that with this option enabled, sometimes this code path intended to handle KeyboardEvents will be entered again after handling a KeyboardEvent with another type of event (CustomEvent); this then later causes this error as
this.current.filteredItemsis nowundefined, as the original KeyboardEvent has already been handled.Checking whether the event looks like a KeyboardEvent, and returning early if it doesn't, appears to resolve this.
Before this change with
spaceSelectsMatchenabled:After this change with
spaceSelectsMatchenabled: