Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 0.13.0-dev.68+b86c4bde6 compatibility #1887

Merged
merged 2 commits into from
May 7, 2024

Conversation

ert78gb
Copy link
Contributor

@ert78gb ert78gb commented May 5, 2024

Summary:

  • use std.fs.cwd().writeFile instead of deprecated std.fs.cwd().writeFile2
  • rename the members of the new std.posix.iovec_const
  • bump minimum_zig_version 0.13.0-dev.33+8af59d1f9 => 0.13.0-dev.68+b86c4bde6

@ert78gb
Copy link
Contributor Author

ert78gb commented May 5, 2024

if I see well one part of this PR covered by #1877

@mochalins
Copy link
Contributor

The minimum Zig version here is incorrect. New iovec field names were not yet introduced here.

@ert78gb
Copy link
Contributor Author

ert78gb commented May 6, 2024

it was introduced in the master. I recognised the LLVM 18 CI issue after I opened the PR. If I see well they are actively working on LLVM. I am keeping my eyes on the zig releases and I will update the PR when the new release will available.

@ert78gb ert78gb marked this pull request as draft May 6, 2024 07:17
@mochalins
Copy link
Contributor

it was introduced in the master. I recognised the LLVM 18 CI issue after I opened the PR. If I see well they are actively working on LLVM. I am keeping my eyes on the zig releases and I will update the PR when the new release will available.

Generally I believe it is best practice for the PR to actually contain the versions necessary for the patch, regardless of whether it is yet available on upstream download links. Regardless, newer Zig versions are now available to the CI.

@ert78gb ert78gb changed the title fix: 0.13.0-dev.46+3648d7df1 compatibility fix: zig-0.13.0-dev.73+db890dbae.tar.xz compatibility May 7, 2024
@ert78gb ert78gb changed the title fix: zig-0.13.0-dev.73+db890dbae.tar.xz compatibility fix: 0.13.0-dev.46+3648d7df1 compatibility May 7, 2024
@ert78gb ert78gb marked this pull request as ready for review May 7, 2024 06:40
@ert78gb ert78gb changed the title fix: 0.13.0-dev.46+3648d7df1 compatibility fix: 0.13.0-dev.68+b86c4bde6 compatibility May 7, 2024
@ert78gb
Copy link
Contributor Author

ert78gb commented May 7, 2024

I updated theminimum_zig_version let me know if I should update something else.

@Techatrix Techatrix force-pushed the fix-zig-46-compatibility branch from 76d9651 to 51a5162 Compare May 7, 2024 09:39
@Techatrix Techatrix linked an issue May 7, 2024 that may be closed by this pull request
ert78gb and others added 2 commits May 7, 2024 11:58
Summary:
- use std.fs.cwd().writeFile instead of deprecated std.fs.cwd().writeFile2
- rename the members of the new std.posix.iovec_const
- bump minimum_zig_version 0.13.0-dev.33+8af59d1f9 => 0.13.0-dev.46+3648d7df1
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/dd37924974b9202f8226ed5d74a252a9785aedf8' (2024-04-24)
  → 'github:NixOS/nixpkgs/27c13997bf450a01219899f5a83bd6ffbfc70d3c' (2024-05-06)
• Updated input 'zig-overlay':
    'github:mitchellh/zig-overlay/751dd89e227c60e89c6362fc5cdd5cb814e3f1ba' (2024-04-26)
  → 'github:mitchellh/zig-overlay/48bcb35d1d59509010af9a3da06af8750ab9593b' (2024-05-07)
@Techatrix Techatrix force-pushed the fix-zig-46-compatibility branch from 51a5162 to ab89dd7 Compare May 7, 2024 09:59
@Techatrix Techatrix merged commit a660910 into zigtools:master May 7, 2024
3 checks passed
@ert78gb ert78gb deleted the fix-zig-46-compatibility branch May 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build under NetBSD/posix
3 participants