-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zetaclient should check 'IsSupported' flag to pause/unpause a specific chain #1969
Conversation
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1969 +/- ##
===========================================
- Coverage 63.08% 62.96% -0.13%
===========================================
Files 233 233
Lines 13381 13407 +26
===========================================
Hits 8442 8442
- Misses 4540 4566 +26
Partials 399 399
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lot of renaming of variables and functions. Also moving the supported check to the client goroutines.
Overall looks good to me. Left some minor comments but approved anyway.
Description
zetaclient
will be able to pause/unpause a specific chain by checking theIsSupported
flag in chain parameters.What will be paused for EVM chain if
IsSupported == false
What will be paused for Bitcoin if
IsSupported == false
Closes: 1883
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: