ci: run build workflow on develop push for code coverage generation #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrubino
approved these changes
Feb 22, 2024
lumtis
added a commit
that referenced
this pull request
Mar 5, 2024
lumtis
added a commit
that referenced
this pull request
Mar 12, 2024
* simplify docker compose * fix makefi;e * add new version * type * fix restart client * some fixes * add light upgrade test * fix gov sending * add admin function test command * performance test * fix lint * add pprof port * some fixes in tests * test: emissions unit test (#1767) * ci: run build workflow on develop push for code coverage generation (#1793) * refactor: zetaclient metrics (#1783) * Refactor zetaclient metrics * Fix blame counter init * Add changelog entry * Add unreleased to changelog * Remove blank line * feat: initiated feature of zetaclient-restricted-address (#1790) * initiated feature of zetaclient-banned-address * fix some issues in e2e tests * fix gosec issues * some unit tests, comments and refactor * unified log prints for restricted address detection * move restricted address to Unreleased section * improved compliance log prints * update compliance log print according to CharlieMc * chore(codecov.yml): fix ignore extension (#1814) * chore(codecov.yml): fix ignore extension * changelog * refactor: remove params from config and introduce app context (#1774) * refactor(`crosschain`): move ballot voting logic into `observer` (#1511) * move logic for ballot voting for inbound * fix mocks * goimports * changelog * fix unit tests * fix CI = * x/observer/keeper/vote_outbound.go x/crosschain/types/expected_keepers.go x/crosschain/keeper/msg_server_vote_outbound_tx.go * update mocks * refactor finalized check * make generate * initialize vote inbound tests * add sdk keepers in observer testutil * implement mock option for observer * inbound vote test * initialize outbound tests * goimports * vote outbound tests * update changelog * test with integration tests * add isNew in vote_inbound * add tests back * use tmp context for ballot logic * add new test for finalized ballot * add not finzalized test * remove unused comment * fix bitcoin credentials * change upgrade version * fix performance tests * handler * fix setup handler * add light flag and use it for upgrade tests * fix username * add performance test back * Update cmd/zetae2e/local/ethereum.go * stefan comments * changelog * fix --------- Co-authored-by: Tanmay <[email protected]> Co-authored-by: skosito <[email protected]> Co-authored-by: Charlie Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run the build-and-test workflow when a new commit is pushed on
develop.This is necessary to get the code coverage generated from develop and being able to check coverage diffs.
While only the unit test job should be necessary for this, I also think it is good to add the full workflow with E2E testing on commit as an extra measure for security.