This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Feature service manager v3 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hotas2k4 just noticed i have the wrong license header |
|
|
||
| class FilterPluginManager extends AbstractPluginManager | ||
| /** | ||
| * @deprecated has simply be moved to the parent directory |
There was a problem hiding this comment.
Why was it moved? Is there a compelling reason to do so?
There was a problem hiding this comment.
Because it's in the wrong folder, look at the folder structure and you will probably understand.
There was a problem hiding this comment.
@macnibblet That's not my point. Moving them breaks backwards compatibility, and I'd like to reduce the number of such breakages. That said, your strategy does work for that, as it's having the originals extend the new ones. So, objection withdrawn. 😄
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
Feature service manager v3
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.