Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2269 Fix JavaScript sample code snippets #2271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

#2269 Fix JavaScript sample code snippets #2271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ The sample code for generating and registering a new key follows:
displayName: "Alex Müller",
},

// This Relying Party will accept either an ES256 or RS256 credential, but
// This Relying Party will accept either an ES256, RS256 or EdDSA credential, but
// prefers an ES256 credential.
pubKeyCredParams: [
{
Expand All @@ -516,6 +516,10 @@ The sample code for generating and registering a new key follows:
{
type: "public-key",
alg: -257 // Value registered by this specification for "RS256"
},
{
type: "public-key",
alg: -8 // "EdDSA" as registered in the IANA COSE Algorithms registry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think EdDSA should be first as this is processed as most preferred to least preferred.

}
],

Expand Down Expand Up @@ -705,7 +709,7 @@ credential registration operation. A similar procedure applies to an authenticat
.then(function (attestation) {
// Register the user.
}).catch(function (error) {
if (error == "AbortError") {
if (error.name === "AbortError") {
// Inform user the credential hasn't been created.
// Let the server know a key hasn't been created.
}
Expand Down Expand Up @@ -1818,6 +1822,7 @@ a numbered step. If outdented, it (today) is rendered as a bullet in the midst o
:: [=list/Append=] the following pairs of {{PublicKeyCredentialType}} and {{COSEAlgorithmIdentifier}} values to |credTypesAndPubKeyAlgs|:
* {{public-key}} and <code>-7</code> ("ES256").
* {{public-key}} and <code>-257</code> ("RS256").
* {{public-key}} and <code>-8</code> ("EdDSA").
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a normative change and should probably be a separate issue and PR.


: is non-zero
:: [=list/For each=] |current| of <code>|pkOptions|.{{PublicKeyCredentialCreationOptions/pubKeyCredParams}}</code>:
Expand Down