#222, #288: Update SHACL-SHACL for general NodeExpression and SelectExpression #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpression Signed-off-by: Alex Nelson <[email protected]>
…lectExpression This patch undoes commit 8632a3e. This was done manually instead of with `git revert`. Signed-off-by: Alex Nelson <[email protected]>
…xpression This is a re-application of commit 8632a3e, done so it can be reviewed in a separate Pull Request. Signed-off-by: Alex Nelson <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
@TallTed , thanks for the peek at this PR. I hadn't intended to request review yet. The PR is intentionally in draft as I think through some syntax things and review some classes. |
...Actually, I'm curious - did you actually comment on this PR (302), or did you just comment once on PR 297? I'm curious if it was actually the latter, and GitHub did an interesting propagation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on a not-currently-merged state of #297 . 297 should be merged before this.
This PR is scoped to SHACL-SHACL updates specific to #222 and #288 . A group decision is not in place on by when this should be merged, or if it blocks PRs or Issues.
This PR is also in a draft status while updates are made over
6bf5a7c, in response to comments on this commit.