Release v0.57.3 #2008
Merged
Release v0.57.3 #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lubronzhan I think your previous changes to remove exclude were not incorporated in the MR? I see you merged that change..can we rebuild? |
Signed-off-by: Lubron Zhan <[email protected]>
lubronzhan
force-pushed
the
topic/lubron/release-0.57.3
branch
from
384e192 to
96d1865
Compare
Signed-off-by: Lubron Zhan <[email protected]>
lubronzhan
force-pushed
the
topic/lubron/release-0.57.3
branch
from
6014ed0 to
7c25084
Compare
Signed-off-by: Lubron Zhan <[email protected]>
lubronzhan
commented
Feb 18, 2025
| @@ -156,7 +151,7 @@ dockerLibraryRegistry: mirror.gcr.io/library | |||
| Then on running conformance: | |||
|
|
|||
| ```bash | |||
| sonobuoy run --sonobuoy-image projects.registry.vmware.com/sonobuoy/sonobuoy:<VERSION> --e2e-repo-config conformance-image-config.yaml | |||
| sonobuoy run --sonobuoy-image sonobuoy/sonobuoy:<VERSION> --e2e-repo-config conformance-image-config.yaml | |||
There was a problem hiding this comment.
Address as mentioned #1987 (review)
lubronzhan
commented
Feb 18, 2025
| @@ -162,7 +157,7 @@ dockerLibraryRegistry: mirror.gcr.io/library | |||
| Then on running conformance: | |||
|
|
|||
| ```bash | |||
| sonobuoy run --sonobuoy-image projects.registry.vmware.com/sonobuoy/sonobuoy:<VERSION> --e2e-repo-config conformance-image-config.yaml | |||
| sonobuoy run --sonobuoy-image sonobuoy/sonobuoy:<VERSION> --e2e-repo-config conformance-image-config.yaml | |||
There was a problem hiding this comment.
Address as mentioned #1987 (review)
lubronzhan
commented
Feb 18, 2025
| @@ -19,7 +19,7 @@ Explicit doc changes (if any) should be made to the appropriate files in directo | |||
| Next, generate a set of versioned docs for v0.x.y. For instance, the new docs be generated by running the command: | |||
|
|
|||
| ``` | |||
| ./scripts/update_docs.sh v0.20.0 | |||
| ./scripts/update_docs.sh -v v0.57.3 -b | |||
There was a problem hiding this comment.
The doc was wrong
|
Move the refactoring of update_docs here #2009 |
Signed-off-by: Lubron Zhan <[email protected]>
sunjayBhatia
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: