Dynamically determine image of plugins #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| nodes: | ||
| - role: control-plane | ||
| image: sonobuoy/kind-node:v1.19.0 | ||
| image: &kind_node_image kindest/node:v1.19.3 |
There was a problem hiding this comment.
Why this change to &kind_node_image kindest/node...
There was a problem hiding this comment.
I thought it'd be more helpful to make sure that the control-plane and worker nodes have consistent versions, instead of manually ensuring they are the same.
added 7 commits
November 17, 2020 11:41
Signed-off-by: Wilson E. Husin <[email protected]>
Signed-off-by: Wilson E. Husin <[email protected]>
- merged images_dynamic.go to images.go - eventually the delta is just new private functions Signed-off-by: Wilson E. Husin <[email protected]>
Signed-off-by: Wilson E. Husin <[email protected]>
Signed-off-by: Wilson E. Husin <[email protected]>
Signed-off-by: Wilson E. Husin <[email protected]>
I'm not sure why we want to maintain yet another image Signed-off-by: Wilson E. Husin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
e2e.test -list-imagesWhich issue(s) this PR fixes
Special notes for your reviewer:
We may not need to do
docker run --rmevery time by caching the results. However, I think that's best addressed in a separate PR as we have discussed about having externalized persistent config.TODO :
cmd/sonobuoy/app/images_dynamic_test.goRelease note: