Fix flag name for systemd-logs image #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag was mistakenly named `systemd-logs-flag` when it should have been `systemd-logs-image`. The existing flag has been left in place but has been marked as hidden and deprecated. It will continue to work but will not appear in the help/usage. Signed-off-by: Bridget McErlean <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
+ Coverage 50.61% 50.75% +0.13%
==========================================
Files 79 79
Lines 5745 5751 +6
==========================================
+ Hits 2908 2919 +11
+ Misses 2662 2659 -3
+ Partials 175 173 -2
Continue to review full report at Codecov.
|
johnSchnake
approved these changes
Jan 8, 2020
zubron
added a commit
to zubron/sonobuoy
that referenced
this pull request
Mar 30, 2020
In vmware-tanzu#1066, we deprecated this flag with the intention of removing it in the 0.18.0 release. Given that we are about to release this version, this flag is now being removed. Signed-off-by: Bridget McErlean <[email protected]>
zubron
added a commit
that referenced
this pull request
Mar 30, 2020
In #1066, we deprecated this flag with the intention of removing it in the 0.18.0 release. Given that we are about to release this version, this flag is now being removed. Signed-off-by: Bridget McErlean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The flag was mistakenly named
systemd-logs-flagwhen it should havebeen
systemd-logs-image. The existing flag has been left in place buthas been marked as hidden and deprecated. It will continue to work but
will not appear in the help/usage.
Signed-off-by: Bridget McErlean [email protected]
Release note: