Tweak website styles for accessibility. #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes most of the fonts a bit bigger, increases contrast, fixes some nits about the spacing in numbered/bulletted lists, and adds some image alt texts. Overall this improves our Lighthouse accessibility score from 71 to 95 and I think it's subjectively more readable. Signed-off-by: Matt Moyer <[email protected]>
mattmoyer
added
enhancement
|
This looks so much better, thank you! Approved on my end. |
michow
pushed a commit
to smalltalk-ai/pinniped
that referenced
this pull request
Feb 23, 2021
michow
added a commit
to smalltalk-ai/pinniped
that referenced
this pull request
Feb 23, 2021
style updates based on vmware-tanzu#426
michow
pushed a commit
to smalltalk-ai/sonobuoy
that referenced
this pull request
Feb 23, 2021
michow
added a commit
to smalltalk-ai/sonobuoy
that referenced
this pull request
Feb 23, 2021
michow
pushed a commit
to smalltalk-ai/contour
that referenced
this pull request
Feb 23, 2021
lspringer
pushed a commit
to smalltalk-ai/pinniped
that referenced
this pull request
Mar 8, 2021
jonasrosland
added a commit
to jonasrosland/sonobuoy
that referenced
this pull request
Mar 16, 2021
jonasrosland
added a commit
to jonasrosland/sonobuoy
that referenced
this pull request
Mar 16, 2021
Signed-off-by: jonasrosland <[email protected]>
jonasrosland
added a commit
to jonasrosland/sonobuoy
that referenced
this pull request
Mar 16, 2021
Signed-off-by: Jonas Rosland <[email protected]>
vladimirvivien
pushed a commit
to vmware-tanzu/sonobuoy
that referenced
this pull request
Mar 17, 2021
* voss-25: update styles to match oss template Signed-off-by: Jonas Rosland <[email protected]> * Code updates -fix headings -fix footer -use bootstrap breakpoints -fix iframe to use bootstrap embed Signed-off-by: Jonas Rosland <[email protected]> * Fix youtube links & add color variables Signed-off-by: Jonas Rosland <[email protected]> * Initial Hugo setup and docs port Signed-off-by: Jonas Rosland <[email protected]> * Fix broken links in docs markdown Signed-off-by: Jonas Rosland <[email protected]> * Add external links to docs Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Move content from Jekyll to Hugo Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: mobile header update and blog tags link Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update config & tag Signed-off-by: Jonas Rosland <[email protected]> * updates to blog feed Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update author tags, getting started link Signed-off-by: Jonas Rosland <[email protected]> * update feed URL Signed-off-by: Jonas Rosland <[email protected]> * Fix hero docs link Signed-off-by: Jonas Rosland <[email protected]> * voss-25: update h2 color Signed-off-by: Jonas Rosland <[email protected]> * Move hugo site to main /site folder Signed-off-by: Jonas Rosland <[email protected]> * Rename logo and update readme Signed-off-by: Jonas Rosland <[email protected]> * Fix content on communities page Signed-off-by: Jonas Rosland <[email protected]> * Update docs styling Signed-off-by: Jonas Rosland <[email protected]> * Change the homepage hero image style Signed-off-by: Jonas Rosland <[email protected]> * Update homepage hero image styling Signed-off-by: Jonas Rosland <[email protected]> * updates based on vmware-tanzu/pinniped#426 Signed-off-by: Jonas Rosland <[email protected]> * updates based on feedback Signed-off-by: Jonas Rosland <[email protected]> * change code color Signed-off-by: Jonas Rosland <[email protected]> * Blog slug permalinks Signed-off-by: Jonas Rosland <[email protected]> * Move imagery to static Signed-off-by: Jonas Rosland <[email protected]> * Add netlify hugo config Signed-off-by: Jonas Rosland <[email protected]> Co-authored-by: Vladimir Vivien <[email protected]>
madamkiwi
pushed a commit
to madamkiwi/sonobuoy
that referenced
this pull request
Mar 18, 2021
* voss-25: update styles to match oss template Signed-off-by: Jonas Rosland <[email protected]> * Code updates -fix headings -fix footer -use bootstrap breakpoints -fix iframe to use bootstrap embed Signed-off-by: Jonas Rosland <[email protected]> * Fix youtube links & add color variables Signed-off-by: Jonas Rosland <[email protected]> * Initial Hugo setup and docs port Signed-off-by: Jonas Rosland <[email protected]> * Fix broken links in docs markdown Signed-off-by: Jonas Rosland <[email protected]> * Add external links to docs Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Move content from Jekyll to Hugo Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: mobile header update and blog tags link Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update config & tag Signed-off-by: Jonas Rosland <[email protected]> * updates to blog feed Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update author tags, getting started link Signed-off-by: Jonas Rosland <[email protected]> * update feed URL Signed-off-by: Jonas Rosland <[email protected]> * Fix hero docs link Signed-off-by: Jonas Rosland <[email protected]> * voss-25: update h2 color Signed-off-by: Jonas Rosland <[email protected]> * Move hugo site to main /site folder Signed-off-by: Jonas Rosland <[email protected]> * Rename logo and update readme Signed-off-by: Jonas Rosland <[email protected]> * Fix content on communities page Signed-off-by: Jonas Rosland <[email protected]> * Update docs styling Signed-off-by: Jonas Rosland <[email protected]> * Change the homepage hero image style Signed-off-by: Jonas Rosland <[email protected]> * Update homepage hero image styling Signed-off-by: Jonas Rosland <[email protected]> * updates based on vmware-tanzu/pinniped#426 Signed-off-by: Jonas Rosland <[email protected]> * updates based on feedback Signed-off-by: Jonas Rosland <[email protected]> * change code color Signed-off-by: Jonas Rosland <[email protected]> * Blog slug permalinks Signed-off-by: Jonas Rosland <[email protected]> * Move imagery to static Signed-off-by: Jonas Rosland <[email protected]> * Add netlify hugo config Signed-off-by: Jonas Rosland <[email protected]> Co-authored-by: Vladimir Vivien <[email protected]>
madamkiwi
pushed a commit
to madamkiwi/sonobuoy
that referenced
this pull request
Mar 18, 2021
* voss-25: update styles to match oss template Signed-off-by: Jonas Rosland <[email protected]> * Code updates -fix headings -fix footer -use bootstrap breakpoints -fix iframe to use bootstrap embed Signed-off-by: Jonas Rosland <[email protected]> * Fix youtube links & add color variables Signed-off-by: Jonas Rosland <[email protected]> * Initial Hugo setup and docs port Signed-off-by: Jonas Rosland <[email protected]> * Fix broken links in docs markdown Signed-off-by: Jonas Rosland <[email protected]> * Add external links to docs Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Move content from Jekyll to Hugo Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: mobile header update and blog tags link Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update config & tag Signed-off-by: Jonas Rosland <[email protected]> * updates to blog feed Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update author tags, getting started link Signed-off-by: Jonas Rosland <[email protected]> * update feed URL Signed-off-by: Jonas Rosland <[email protected]> * Fix hero docs link Signed-off-by: Jonas Rosland <[email protected]> * voss-25: update h2 color Signed-off-by: Jonas Rosland <[email protected]> * Move hugo site to main /site folder Signed-off-by: Jonas Rosland <[email protected]> * Rename logo and update readme Signed-off-by: Jonas Rosland <[email protected]> * Fix content on communities page Signed-off-by: Jonas Rosland <[email protected]> * Update docs styling Signed-off-by: Jonas Rosland <[email protected]> * Change the homepage hero image style Signed-off-by: Jonas Rosland <[email protected]> * Update homepage hero image styling Signed-off-by: Jonas Rosland <[email protected]> * updates based on vmware-tanzu/pinniped#426 Signed-off-by: Jonas Rosland <[email protected]> * updates based on feedback Signed-off-by: Jonas Rosland <[email protected]> * change code color Signed-off-by: Jonas Rosland <[email protected]> * Blog slug permalinks Signed-off-by: Jonas Rosland <[email protected]> * Move imagery to static Signed-off-by: Jonas Rosland <[email protected]> * Add netlify hugo config Signed-off-by: Jonas Rosland <[email protected]> Co-authored-by: Vladimir Vivien <[email protected]>
madamkiwi
pushed a commit
to madamkiwi/sonobuoy
that referenced
this pull request
Mar 18, 2021
* voss-25: update styles to match oss template Signed-off-by: Jonas Rosland <[email protected]> * Code updates -fix headings -fix footer -use bootstrap breakpoints -fix iframe to use bootstrap embed Signed-off-by: Jonas Rosland <[email protected]> * Fix youtube links & add color variables Signed-off-by: Jonas Rosland <[email protected]> * Initial Hugo setup and docs port Signed-off-by: Jonas Rosland <[email protected]> * Fix broken links in docs markdown Signed-off-by: Jonas Rosland <[email protected]> * Add external links to docs Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Move content from Jekyll to Hugo Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: mobile header update and blog tags link Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update config & tag Signed-off-by: Jonas Rosland <[email protected]> * updates to blog feed Signed-off-by: Jonas Rosland <[email protected]> * Voss-25: Update author tags, getting started link Signed-off-by: Jonas Rosland <[email protected]> * update feed URL Signed-off-by: Jonas Rosland <[email protected]> * Fix hero docs link Signed-off-by: Jonas Rosland <[email protected]> * voss-25: update h2 color Signed-off-by: Jonas Rosland <[email protected]> * Move hugo site to main /site folder Signed-off-by: Jonas Rosland <[email protected]> * Rename logo and update readme Signed-off-by: Jonas Rosland <[email protected]> * Fix content on communities page Signed-off-by: Jonas Rosland <[email protected]> * Update docs styling Signed-off-by: Jonas Rosland <[email protected]> * Change the homepage hero image style Signed-off-by: Jonas Rosland <[email protected]> * Update homepage hero image styling Signed-off-by: Jonas Rosland <[email protected]> * updates based on vmware-tanzu/pinniped#426 Signed-off-by: Jonas Rosland <[email protected]> * updates based on feedback Signed-off-by: Jonas Rosland <[email protected]> * change code color Signed-off-by: Jonas Rosland <[email protected]> * Blog slug permalinks Signed-off-by: Jonas Rosland <[email protected]> * Move imagery to static Signed-off-by: Jonas Rosland <[email protected]> * Add netlify hugo config Signed-off-by: Jonas Rosland <[email protected]> Co-authored-by: Vladimir Vivien <[email protected]> Signed-off-by: Kalai Wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes most of the fonts a bit bigger, increases contrast, fixes some nits about the spacing in numbered/bulletted lists, and adds some image alt texts.
Overall this improves our Lighthouse accessibility score from 71 to 95 and I think it's subjectively more readable.
Release note:
Comparisons
The changes are relatively subtle but are more obvious on pages with big blocks of text, such as the recent blog post:
Before
After
The full preview deployment is here: https://deploy-preview-426--pinniped.netlify.app/