Dockerized version #152
Open
Dockerized version #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadzhou
reviewed
Mar 8, 2025
|
|
||
| # Set default command with -u flag for unbuffered output | ||
| ENTRYPOINT ["poetry", "run", "python", "-u", "src/main.py"] | ||
| CMD ["--ticker", "AAPL,MSFT,NVDA"] # Optional default arguments |
r0b2g1t
reviewed
Mar 8, 2025
| @@ -0,0 +1,34 @@ | |||
| # Use Python 3.10 slim image as base | |||
| FROM python:3.10-slim | |||
There was a problem hiding this comment.
May change it to python 3.13. Python 3.10 will be end of life next year.
| @@ -126,6 +126,18 @@ You can optionally specify the start and end dates to backtest over a specific t | |||
| poetry run python src/backtester.py --ticker AAPL,MSFT,NVDA --start-date 2024-01-01 --end-date 2024-03-01 | |||
| ``` | |||
|
|
|||
| ## Using Docker | |||
|
|
|||
There was a problem hiding this comment.
Add the info to create a .env file first.
| # Copy source code | ||
| COPY src/ src/ | ||
| COPY .env . | ||
| COPY .gitignore . |
| COPY src/ src/ | ||
| COPY .env . | ||
| COPY .gitignore . | ||
| COPY README.md . |
| COPY .env . | ||
| COPY .gitignore . | ||
| COPY README.md . | ||
| COPY LICENSE . |
| RUN apt-get update && apt-get install -y \ | ||
| gcc \ | ||
| python3-dev \ | ||
| curl \ |
There was a problem hiding this comment.
Not needed when you use "pip install poetry"
| curl \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN curl -sSL https://install.python-poetry.org | python3 - |
There was a problem hiding this comment.
Use "pip install poetry" to get rid of curl
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN curl -sSL https://install.python-poetry.org | python3 - | ||
| ENV PATH="/root/.local/bin:$PATH" |
There was a problem hiding this comment.
You can combine this with line 30 to remove this docker layer:
ENV PYTHONUNBUFFERED=1
PATH="/root/.local/bin:$PATH"
|
I think this PR can be closed as PR #154 contains the Dockerfile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a Dockerfile which creates a reproducible container.
Also updated README w/ instructions.