Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typing): Follow-up fix _from_array_like #3812

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Feb 28, 2025

Have a better understanding now of what the issue is in (https://github.com/narwhals-dev/narwhals/actions/runs/13577097131/job/37955718895).

altair/utils/schemapi.py:497: error: No overload variant of "from_native"
matches argument types "Iterable[Any]", "bool"  [call-overload]
            ser = nw.from_native(obj, series_only=True)
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
altair/utils/schemapi.py:497: note: Possible overload variants:

Related

Update

Fixed it 🙂 (narwhals-dev/narwhals#2114 (comment))

Have a better understanding *now* of what the issue is in (https://github.com/narwhals-dev/narwhals/actions/runs/13577097131/job/37955718895).

- This patch is *functionally* the same - but removes the need for ignoring a (typing) warning following (narwhals-dev/narwhals@62f8a1f).
- Should also mean we don't need to bump our `narwhals` minimum [again](#3807 (comment)).
- **Bonus**: reduced overhead for `<3.11` (python/cpython#84403)

## Related
- narwhals-dev/narwhals#2110
- #3811
- narwhals-dev/narwhals#2110 (comment)
- narwhals-dev/narwhals#2110 (comment)
- narwhals-dev/narwhals#2111
@dangotbanned dangotbanned marked this pull request as ready for review February 28, 2025 12:17
@dangotbanned dangotbanned changed the title chore(typing): Follup-up fix _from_array_like chore(typing): Follow-up fix _from_array_like Feb 28, 2025
@dangotbanned
Copy link
Member Author

Wow 🤦‍♂️ #3812 (comment)

@dangotbanned dangotbanned enabled auto-merge (squash) February 28, 2025 12:18
@dangotbanned dangotbanned merged commit 7ba280e into main Feb 28, 2025
27 checks passed
@dangotbanned dangotbanned deleted the nw-from-array-like-patch branch February 28, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant