feat: support grpc stream for data plane #352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyjiangkai <[email protected]>
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
f285759 to
64ce0a2
Compare
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
64ce0a2 to
72be0cc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 62.72% 59.02% -3.71%
==========================================
Files 133 172 +39
Lines 12128 14220 +2092
==========================================
+ Hits 7607 8393 +786
- Misses 3977 5225 +1248
- Partials 544 602 +58
Continue to review full report at Codecov.
|
wenfengwang
suggested changes
Dec 19, 2022
Signed-off-by: jyjiangkai <[email protected]>
ifplusor
reviewed
Dec 20, 2022
ifplusor
requested changes
Dec 20, 2022
…m-v2 Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
ed2616f to
804f744
Compare
ifplusor
changed the title
ifplusor
requested changes
Dec 22, 2022
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
734120b to
2278c46
Compare
ifplusor
requested changes
Dec 23, 2022
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
16661cb to
b704d31
Compare
ifplusor
reviewed
Dec 23, 2022
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
b704d31 to
6843243
Compare
ifplusor
requested changes
Dec 23, 2022
| if stderr.Is(err, io.EOF) { | ||
| s.appendStream.CloseSend() | ||
| s.appendStream = nil | ||
| c, _ := s.appendCallbacks.LoadAndDelete(opaqueID) |
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
6843243 to
101e46b
Compare
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
101e46b to
83363a1
Compare
…m-v2 Signed-off-by: jyjiangkai <[email protected]>
ifplusor
reviewed
Dec 28, 2022
ifplusor
reviewed
Dec 28, 2022
ifplusor
reviewed
Dec 28, 2022
ifplusor
reviewed
Dec 28, 2022
ifplusor
requested changes
Dec 28, 2022
hwjiangkai
force-pushed
the
clientstream-v2
branch
2 times, most recently
from
c527fad to
e3f573e
Compare
…m-v2 Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
e3f573e to
98dc0f9
Compare
ifplusor
requested changes
Dec 30, 2022
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
6ce31f8 to
86a6f0e
Compare
hwjiangkai
force-pushed
the
clientstream-v2
branch
2 times, most recently
from
1460868 to
1f7ad23
Compare
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
1f7ad23 to
b4423f7
Compare
ifplusor
requested changes
Jan 9, 2023
internal/store/segment/api.go
Outdated
Comment on lines
214
to
215
| errCode = errpb.ErrorCode_UNKNOWN | ||
| errMsg = "unknown" |
There was a problem hiding this comment.
remains detail of ErrorType.
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
a46f7e6 to
905abf6
Compare
ifplusor
requested changes
Jan 10, 2023
internal/store/segment/api.go
Outdated
| errCode = errpb.ErrorCode_APPEND_TO_BLOCK_FAILED | ||
| errMsg = "append to block failed" | ||
| } | ||
| log.Error(ctx, "append to block failed", map[string]interface{}{ |
internal/store/segment/api.go
Outdated
| request, err := stream.Recv() | ||
| if err != nil { | ||
| if stderr.Is(err, io.EOF) { | ||
| log.Warning(ctx, "append stream closed", map[string]interface{}{ |
There was a problem hiding this comment.
EOF is ok, don't use Warning and Error
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
905abf6 to
1913655
Compare
Signed-off-by: jyjiangkai <[email protected]>
hwjiangkai
force-pushed
the
clientstream-v2
branch
from
1913655 to
73b43c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
transport layer performance optimization
Issue Number: close #xxx
Problem Summary
What is changed and how does it work?
Check List
Tests