Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): rename uniond bin in release workflow #1040

Merged

Conversation

PoisonPhang
Copy link
Contributor

@PoisonPhang PoisonPhang commented Dec 13, 2023

Summary by CodeRabbit

  • Chores
    • Modified workflow file to change file renaming logic based on certain conditions.

@PoisonPhang PoisonPhang self-assigned this Dec 13, 2023
@PoisonPhang PoisonPhang linked an issue Dec 13, 2023 that may be closed by this pull request
Copy link

coderabbitai bot commented Dec 13, 2023

Walkthrough

The recent changes include modifications to a workflow file, specifically altering the logic for file renaming based on certain conditions. Previously, the file renaming was based on the values of matrix.package and matrix.system, but now it renames the file as uniond-${{ matrix.system }} under specific circumstances.

Changes

File Change Summary
.github/workflows/release.yml Modifies a shell script within a workflow file, changing the behavior of a conditional block related to file renaming. Specifically, it alters the logic for renaming a file based on the value of matrix.package and matrix.system. Previously, the script renamed a file using the format ${{ matrix.package }}-${{ matrix.system }}, but now it renames the file as uniond-${{ matrix.system }} under certain conditions.

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@PoisonPhang PoisonPhang merged commit 77557fd into main Dec 13, 2023
@PoisonPhang PoisonPhang deleted the 1039-release-workflow-fails-because-of-uniond-rename branch December 13, 2023 20:17
PoisonPhang added a commit that referenced this pull request Dec 13, 2023
* fix(ci): rename uniond output bin

* chore(ci): remove debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow fails because of uniond rename
2 participants