Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): mv uniond binary correctly #1038

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix(ci): mv uniond binary correctly #1038

merged 3 commits into from
Dec 13, 2023

Conversation

PoisonPhang
Copy link
Contributor

@PoisonPhang PoisonPhang commented Dec 13, 2023 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated release workflow to improve file and directory renaming logic.

@PoisonPhang PoisonPhang self-assigned this Dec 13, 2023
@PoisonPhang PoisonPhang linked an issue Dec 13, 2023 that may be closed by this pull request
dl-bins step fails in release workflow #1037
Closed
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 13, 2023 •
edited
Loading

Walkthrough

The workflow file release.yml has been updated to modify the conditional logic within the jobs section. The condition now checks if the matrix package matches the pattern "uniond-release" instead of "galoisd-*", leading to the renaming of a file or directory if the condition is met.

Changes

File Summary
.github/workflows/release.yml Modified conditional logic within the jobs section to rename a file or directory based on the matrix package matching the pattern "uniond-release" instead of "galoisd-*".

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@PoisonPhang PoisonPhang merged commit 2bd7858 into main Dec 13, 2023
@PoisonPhang PoisonPhang deleted the 1037-dl-bins-step-fails-in-release-workflow branch December 13, 2023 19:25
PoisonPhang added a commit that referenced this pull request Dec 13, 2023
@PoisonPhang
fix(ci): mv uniond binary correctly (#1038)
40dcbc8 
* fix(ci): debug file structure

* fix(ci): specail case for uniond bin download

* chore(ci): remove debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeryz aeryz aeryz approved these changes

@benluelo benluelo benluelo approved these changes

Assignees

@PoisonPhang PoisonPhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dl-bins step fails in release workflow
3 participants
@PoisonPhang @aeryz @benluelo