UNI-1020 safe downcasting arithmetic operation.

[twygod]

No description provided.

[linear]

UNI-1020 #96 - Unsafe downcasting arithmetic operation in UserManager related contract and in UToken.sol

sherlock-audit/2022-10-union-finance-judging#96

[Has Dupes: 2, 62]

[maxweng]

LGTM

[dmitriia]

Looks ok, but here safecast still needs to be added:

union-v2-contracts/contracts/user/UserManager.sol

Lines 720 to 724 in 49d1a72

	uint256 remaining = IAssetManager(assetManager).withdraw(stakingToken, msg.sender, amount);
	if (uint96(remaining) > amount) {
	revert AssetManagerWithdrawFailed();
	}
	uint96 actualAmount = amount - uint96(remaining);

        uint256 remaining = IAssetManager(assetManager).withdraw(stakingToken, msg.sender, amount);
        if (uint96(remaining) > amount) {
            revert AssetManagerWithdrawFailed();
        }
        uint96 actualAmount = amount - uint96(remaining);