Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: stop using redirects in collections #18112

Merged

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jan 24, 2025

This is not a certain fix, but we generally seen redirects as bad.
Its because we sometimes have a case where the browser loads the Media section before Content, and a redirect of the Media Section changes the URl so they user now stays on Media, despite the user did not want to navigate to the media section.

It only happens occasionally so this is more of a try, by doing the thing we have done elsewhere to fix this issue — which is stop using redirects. :-D

Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This also resolves another issue where navigating to a folder (Ex. Document Types Root) would not highlight the sidebar menu item as active due to the redirects. 👍

@madsrasmussen madsrasmussen merged commit 9c02fb4 into v15/dev Jan 24, 2025
30 checks passed
@madsrasmussen madsrasmussen deleted the v15/bugfix/stop-using-redirects-in-collections branch January 24, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants