Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does max_concurrency work for a pipeline step? #815

Closed
e-gineer opened this issue Mar 26, 2024 · 2 comments
Closed

Does max_concurrency work for a pipeline step? #815

e-gineer opened this issue Mar 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@e-gineer
Copy link
Contributor

Version: v0.4.2

  step "pipeline" "approve" {
    for_each = param.approvers

    max_concurrency = 1

    pipeline = pipeline.single_approval

    args = {
      approver = each.value
      subject = param.subject
      prompt = param.prompt
      timeout = param.timeout
      default_decision = param.default_decision
    }
  }

I believe that the pipeline step does not respect max_concurrency? It is triggering my child pipeline multiple times in parallel even if I have max_concurrency set to 1.

Also - it's hard to debug / tell ... because the verbose output does not display the value of the max_concurrency arg?

2024-03-26 07:05:24 exec_co1ant4o47mg84ftbg8g [approve.approve[0]] Starting pipeline
2024-03-26 07:05:24 exec_co1ant4o47mg84ftbg8g [approve.approve[0]] Arg args = {
  "approver": "foo",
  "default_decision": false,
  "prompt": "Should I square 2?",
  "subject": "Should I square 2?",
  "timeout": 10
}
2024-03-26 07:05:24 exec_co1ant4o47mg84ftbg8g [approve.approve[0]] Arg pipeline = approval.pipeline.single_approval
2024-03-26 07:05:24 exec_co1ant4o47mg84ftbg8g [approve.approve[1]] Starting pipeline
2024-03-26 07:05:24 exec_co1ant4o47mg84ftbg8g [approve.approve[1]] Arg args = {
  "approver": "bar",
  "default_decision": false,
  "prompt": "Should I square 2?",
  "subject": "Should I square 2?",
  "timeout": 10
}
2024-03-26 07:05:24 exec_co1ant4o47mg84ftbg8g [approve.approve[1]] Arg pipeline = approval.pipeline.single_approval
@e-gineer e-gineer added the bug Something isn't working label Mar 26, 2024
@vhadianto
Copy link
Contributor

Bug caused by async execution of nested pipeline.

@vhadianto
Copy link
Contributor

Fixed in v0.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants