Fix cases when using where_object_changes_* with nil values #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepiske
changed the title
andrepiske
commented
Feb 12, 2025
andrepiske
changed the title
cuchi
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, so this PR initially began as a bug report, which is down below, and then turns out there was another more serious bug, which is that when using
IronTrail::ChangeModelConcern#where_object_changes_(to|from)methods wiht a nil value, it'd break. This PR fixes that and also the bug described below.Original bug report:
When ActiveRecord SQL Query Comments is enabled, AR will automatically disable prepared statements.
Without prepared statements, a test breaks like here: https://github.com/trusted/iron_trail/actions/runs/13052410073/job/36415455364
The fix is easy and just constitutes in converting the incoming value to a string, since the->>JSON operator in PostgreSQL always returns a string, no matter the value type in the json object.Asana link