feat: resolve ~ paths
#875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simbleau
commented
Sep 13, 2024
Cargo.toml
Outdated
| tokio-tungstenite = "0.23" | ||
| toml = "0.8" | ||
| tower-http = { version = "0.5.1", features = ["fs", "trace", "set-header"] } | ||
| tracing = "0.1" | ||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } | ||
| which = "6" | ||
| zip = "2" | ||
| homedir = "0.3.3" |
There was a problem hiding this comment.
This was the only real change on this page, the rest was rustfmt.
There was a problem hiding this comment.
Could you sort that alphabetically.
|
I'd prefer to keep the dependencies as one liners, and sort them alphabetically. Which Rust Rover can easily do, if dependencies are one liners 😉 |
ctron
reviewed
Sep 13, 2024
src/config/rt/serve.rs
Outdated
| @@ -250,7 +250,21 @@ fn absolute_path_if_some( | |||
| file_description: &str, | |||
| ) -> anyhow::Result<Option<PathBuf>, anyhow::Error> { | |||
| match maybe_path { | |||
| Some(path) => Ok(Some(absolute_path(path, file_description)?)), | |||
| Some(path) => { | |||
| let path = if path.display().to_string().contains('~') { | |||
There was a problem hiding this comment.
I think we can go with to_string_lossy, which should prevent allocation and might be a bit shorter.
|
Looks quick and simple. Love it. |
ctron
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #872