Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install trunk #842

Closed
Baptistemontan opened this issue Aug 6, 2024 · 4 comments
Closed

Can't install trunk #842

Baptistemontan opened this issue Aug 6, 2024 · 4 comments

Comments

@Baptistemontan
Copy link

When installing trunk on local and CI I get this error:

error[E0004]: non-exhaustive patterns: `&SelectorParseErrorKind::AmbiguousCssModuleClass(_)` not covered
   --> C:\Users\bapti\.cargo\registry\src\index.crates.io-6f17d22bba15001f\lightningcss-1.0.0-alpha.55\src\error.rs:266:11
    |
266 |     match &err {
    |           ^^^^ pattern `&SelectorParseErrorKind::AmbiguousCssModuleClass(_)` not covered
    |
note: `SelectorParseErrorKind<'_>` defined here
   --> C:\Users\bapti\.cargo\registry\src\index.crates.io-6f17d22bba15001f\parcel_selectors-0.26.6\parser.rs:188:1
    |
188 | pub enum SelectorParseErrorKind<'i> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
201 |   AmbiguousCssModuleClass(CowRcStr<'i>),
    |   ----------------------- not covered
    = note: the matched value is of type `&SelectorParseErrorKind<'_>`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
    |
299 ~       SelectorParseErrorKind::ClassNeedsIdent(t) => SelectorError::ClassNeedsIdent(t.into()),
300 ~       &SelectorParseErrorKind::AmbiguousCssModuleClass(_) => todo!(),

This is due to a new version of parcel_selectors, v0.26.6, does not work with lightningcss v1.0.0-alpha.55 because a new variant of a public enum has been introduced.

I see that the main branch of trunk is pinning lightningcss to =v1.0.0-alpha.57, the latest version that works with parcel_selectors v0.26.6 is alpha.58.

@ctron
Copy link
Collaborator

ctron commented Aug 6, 2024

Can you try installing with --locked?

@Baptistemontan
Copy link
Author

--locked did fixed the issue, thanks!

ctron added a commit to ctron/trunk that referenced this issue Aug 6, 2024
@ctron
Copy link
Collaborator

ctron commented Aug 6, 2024

I did update the deps anyway!

@ctron
Copy link
Collaborator

ctron commented Aug 7, 2024

I released a new version (0.20.3) just with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants