Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist Server-side Preparations #425

Merged
merged 9 commits into from
Feb 14, 2025
Merged

Conversation

hasezoey
Copy link
Contributor

This PR is a collection of changes in preparation for doing #152 cleanly (to be better reviewable). In more details:

  • rename playback.rs to music_service_client.rs to be consistent with the server and be better find-able
  • remove serde from termusic-playback as it has never been necessary there
  • add a TuiCmd enum to use for tui command instead of sharing PlayerCmd (this is later necessary as both may need to carry different data, also now we can exhaustively match in the tui)
  • dont cycle the playlist Loop-Mode in the tui, return it from the server on request and use that instead
  • remove some unused variants from PlayerCmd
  • remove Default impl for Playlist as it basically is not used and new should be used instead and match / error on the result
  • add a new function to the podcast db to get a episode by it URI / URL
  • some other general style changes

@hasezoey hasezoey changed the title Playlist Service Preparations Playlist Server-side Preparations Feb 12, 2025
@tramhao tramhao merged commit 842cd05 into tramhao:master Feb 14, 2025
5 checks passed
@hasezoey hasezoey deleted the playlistPrep branch February 14, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants