Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collection of changes in preparation for doing #152 cleanly (to be better reviewable). In more details:
playback.rs
tomusic_service_client.rs
to be consistent with the server and be better find-ableserde
fromtermusic-playback
as it has never been necessary thereTuiCmd
enum to use for tui command instead of sharingPlayerCmd
(this is later necessary as both may need to carry different data, also now we can exhaustively match in the tui)PlayerCmd
Default
impl forPlaylist
as it basically is not used andnew
should be used instead and match / error on the result