Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Skip router if no routers configured #1915

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

henadzit
Copy link
Contributor

@henadzit henadzit commented Mar 3, 2025

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #1915 will not alter performance

Comparing henadzit:perf/router (8607a24) with develop (a399d1a)

Summary

✅ 16 untouched benchmarks

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13634893643

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 89.348%

Files with Coverage Reduction New Missed Lines %
tortoise/router.py 7 51.06%
Totals Coverage Status
Change from base Build 13634120781: -0.09%
Covered Lines: 6592
Relevant Lines: 7198

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants