Skip to content

Commit

Permalink
feat: switch to native Promises for async APIs
Browse files Browse the repository at this point in the history
- All async APIs now use native Promises -- no more Task or
CancellablePromise
- The cancellation API is mostly new. Command chains still provide a
`cancel` method. Tests, suites, and exector runs can be cancelled by
calling `cancel` on the test, suite, or executor.

references #1018

BREAKING CHANGE: async APIs now return native Promises, and
the cancellation API is entirely new
  • Loading branch information
jason0x43 committed Feb 17, 2020
1 parent 8d86677 commit b31f7d8
Show file tree
Hide file tree
Showing 65 changed files with 2,277 additions and 2,810 deletions.
7 changes: 6 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
// TODO: turn this back on when we're ready to fix all the usages
"@typescript-eslint/no-non-null-assertion": "off",
// The whole point of ts-ignore is to purposefully ignore errors...
"@typescript-eslint/ban-ts-ignore": "off"
"@typescript-eslint/ban-ts-ignore": "off",
// It's OK to return values and ignore them
"@typescript-eslint/no-misused-promises": [
"error",
{ "checksVoidReturn": false }
]
}
}
3 changes: 1 addition & 2 deletions src/common/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export { default as Task } from './lib/Task';
export * from './lib/Task';
export * from './lib/cancel';

export { default as Evented } from './lib/Evented';
export * from './lib/Evented';
Expand Down
Loading

0 comments on commit b31f7d8

Please sign in to comment.