Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export: add fit to screen mode to exported svg #601

Merged
merged 8 commits into from
Jan 4, 2023

Conversation

berniexie
Copy link
Contributor

@berniexie berniexie commented Jan 3, 2023

Also fixes the issue where it refits to screen on every watch refresh.

scripts in svgs won't run when they're embeded in an html document so the script won't run twice in watch mode.

@berniexie
Copy link
Contributor Author

@alixander what do we do about the sketch tests

@berniexie berniexie requested a review from nhooyr January 3, 2023 23:01
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment about why it doesn't run again with --watch.

@alixander
Copy link
Collaborator

@alixander what do we do about the sketch tests

i don't understand what the issue is

@berniexie berniexie requested a review from alixander January 4, 2023 00:47
@berniexie berniexie marked this pull request as ready for review January 4, 2023 00:47
@berniexie berniexie merged commit 80892f9 into terrastruct:master Jan 4, 2023
@berniexie berniexie deleted the 540/fit-to-screen-fix branch January 4, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants