Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: fix connection masking in firefox #453

Merged
merged 4 commits into from
Dec 17, 2022

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Dec 17, 2022

Summary

Fixes a bug where connections would appear strangely in firefox since they would have an undefined mask when there are no connection labels.

Details

before/after

Screen Shot 2022-12-16 at 5 19 17 PM

@gavin-ts gavin-ts marked this pull request as ready for review December 17, 2022 01:26
@gavin-ts gavin-ts requested a review from a team December 17, 2022 01:26
@gavin-ts gavin-ts enabled auto-merge December 17, 2022 01:27
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@gavin-ts gavin-ts merged commit 5faa45d into terrastruct:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The connections on the right are not displayed correctly.
2 participants