-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add validate command #2415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for taking this!
For the error case, can we just print out the errors without "failed to validate"? Technically, it successfully validated it to be incorrect.
For success, I always like printing something out to let users know their command worked. "Success! [x.d2] is valid D2."
Can you add a test to e2etests-cli please?
Yeah, we should be able to do that.
Sure, I also thought about that, for better ux.
I'll look into it. |
Hey @alixander, should we print "Success! input is valid D2." in case of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sign your commits please? We have it as an org-wide setting
8b045cd
to
b8742f7
Compare
Hey @alixander, updated the PR with signed commits and updated with your suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/fixes #2410