Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: support center in d2-config #2360

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

x-delfino
Copy link
Contributor

This PR fixes support for center in d2-config variables. Looks like it was only partially implemented but should be supported per documentation.

Test file:

vars: {
  d2-config: {
    center: true
  }
}

x -> y

before change:

preserveAspectRatio="xMinYMin meet"

after change:

preserveAspectRatio="xMidYMid meet"

Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, ty!

@alixander alixander merged commit 7741382 into terrastruct:master Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants