reserved keywords must be unquoted #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
force-pushed
the
reserve-unquoted-string
branch
from
35a4c4a to
1ecadc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #477
This is a big refactor that preserves the original form of the user input into the compiler step (instead of using the formatted version). This allows multiple places in the compilation to check that the user input was unquoted, and if so, don't count it as reserved (among other things, like underscores).
I'm sure I missed some spot where quoting/unquoting is going to result in weirdness -- there's not enough comprehensive tests that exercise quotation to have confidence. But that's okay, this is kind of edge case in that it's mostly useful SQL table and Class shapes. In those instances, the key itself is output to the render, and label is something else. In all other cases, you'd probably just relabel the key instead of using quotes everywhere to try to use a reserved keyword.