Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect domain in for new cloud #7129

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

JoshK2
Copy link
Member

@JoshK2 JoshK2 commented Mar 8, 2023

Proposed Changes

Check if the workspace is running locally. If yes, there is no change, and it still go to bit.cloud hardcoded URL.
And if it's not running locally, use the origin domain for the URL. So it will work on both bit.cloud and new cloud.

@JoshK2 JoshK2 requested review from GiladShoham and guysaar223 March 8, 2023 12:26
@GiladShoham GiladShoham enabled auto-merge (squash) March 8, 2023 14:51
@GiladShoham GiladShoham disabled auto-merge March 8, 2023 16:07
@GiladShoham GiladShoham merged commit ea05129 into master Mar 8, 2023
@GiladShoham GiladShoham deleted the fix-incorrect-url-in-env-tooltip-1 branch March 8, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants