Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit import should save the component in package.json with relative path #506

Closed
davidfirst opened this issue Jan 1, 2018 · 0 comments
Closed

Comments

@davidfirst
Copy link
Member

davidfirst commented Jan 1, 2018

in the project and not as an npm package. (e.g. @bit/is-string: ./components/is-string).

If a component was a dependency before and was saved in package.json as an npm package, change it to be a relative path in the project upon bit import.

This task should solve the following issue:
A user writes code that would be published as an npm package. In his local development environment, he imported a component using 'bit import' command and required it in his source code with the absolute syntax '@bit/component'. On his local, it works because of the symlink generated from ./components to node_modules/@bit. However, users who install his package, won't get this symlink, which results in a broken package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants