Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding imported component #495

Closed
GiladShoham opened this issue Dec 31, 2017 · 2 comments
Closed

Adding imported component #495

GiladShoham opened this issue Dec 31, 2017 · 2 comments
Assignees
@amitgilad3
Labels
area/add type/bug
Milestone
5.1.17

Comments

@GiladShoham
Copy link
Member

During bit add we should check if a folder path is a root dir of a component, if yes we should add the new files to this component and not as new component
@GiladShoham GiladShoham added this to the 4.1.17 milestone Dec 31, 2017
@ghost ghost added the in progress label Jan 1, 2018
@amitgilad3
Copy link
Contributor

@itaymendel - can you please send me output for the following cases:

  1. add to imported component without specifying id
  2. add to imported component without specifying correct id

@itaymendel
Copy link
Contributor

  1. error - unable to add new files to the imported component [component ID] without specifying '--id'.
  2. error - unable to add new files from the root directory of the imported component [imported component ID] to [component ID].

amitgilad3 added a commit that referenced this issue Jan 4, 2018
@amitgilad3
Merge branch 'master' into bug/#495-adding-imported-component
7aaa8cf
amitgilad3 pushed a commit that referenced this issue Jan 8, 2018
Merge remote-tracking branch 'origin/master' into bug/#495-adding-imp…
77c29b0 
…orted-component2

# Conflicts:
#	CHANGELOG.md
@GiladShoham GiladShoham mentioned this issue Jan 9, 2018
Merged
amitgilad3 pushed a commit that referenced this issue Jan 9, 2018
Merge remote-tracking branch 'origin/master' into bug/#495-adding-imp…
a90f285 
…orted-component2

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amitgilad3 amitgilad3

Labels
area/add type/bug
Projects
None yet
Milestone
5.1.17
Development

No branches or pull requests
3 participants
@GiladShoham @itaymendel @amitgilad3