Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component is added as a dependency upon import even when using --ignore-package-json flag #1988

Closed
davidfirst opened this issue Sep 9, 2019 · 0 comments · Fixed by #1989
Closed
Labels

Comments

@davidfirst
Copy link
Member

Describe the bug

When importing a component with --ignore-package-json flag, the component's root dir, doesn't have the package.json file, so there is no point of adding that component with the relative-path into the workspace's package.json file.

Steps to Reproduce

  1. import a component with --ignore-package-json flag.
  2. run npm install twice.
  3. the following error is thrown
npm ERR! Cannot read property 'match' of undefined

Expected Behavior

No records should be added into root package.json when --ignore-package-json is used.

Specifications

  • Bit version: 14.2.5
  • Node version: v12.7.0
  • npm / yarn version: npm 6.9.0
  • Platform: Mac
  • Bit compiler (include version): N/A
  • Bit tester (include version): N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant