Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aide-axum): properly infer response descriptions #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snejugal
Copy link

subschema_for is likely to return just a reference to a schema, and it will not contain any metadata. However, axum::Json (and axum::Form) do not try to resolve the reference before extracting schema description, and that leaves blank response descriptions in rendered docs. So I added a call to resolve_schema to ensure that we get the actual schema before extracting its description.

@JakkuSakura
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants