Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove auto provision, simplify js hs api #334

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

autodidaddict
Copy link
Contributor

This PR does a few main things:

  • changes behavior so that host services resources (currently kv, objectStore) are never automatically provisioned
  • JS API for host services has been changed as per Simplify and Improve Host Services Developer Experience #332
  • Fixed a bug in host services calls that didn't return an error propagated from the service itself

@autodidaddict autodidaddict requested a review from a team as a code owner August 1, 2024 14:44
@autodidaddict
Copy link
Contributor Author

This is a new error I've never seen before (macos test):

fatal error: concurrent map writes

goroutine 2704 [running]:
github.com/synadia-io/nex/internal/node.(*WorkloadManager).agentHandshakeSucceeded(0x140008bac30, {0x140006e2930, 0x24})
	/Users/runner/work/nex/nex/internal/node/workload_mgr.go:521 +0xa8

@autodidaddict autodidaddict requested a review from kthomas August 1, 2024 15:41
@kthomas
Copy link
Contributor

kthomas commented Aug 1, 2024

This is a new error I've never seen before (macos test):

fatal error: concurrent map writes

goroutine 2704 [running]:
github.com/synadia-io/nex/internal/node.(*WorkloadManager).agentHandshakeSucceeded(0x140008bac30, {0x140006e2930, 0x24})
	/Users/runner/work/nex/nex/internal/node/workload_mgr.go:521 +0xa8

@jordan-rash saw this yesterday, also on macos. Taking a look at this...

Update: opened #335 to address.

@jordan-rash
Copy link
Contributor

This is a new error I've never seen before (macos test):

fatal error: concurrent map writes

goroutine 2704 [running]:
github.com/synadia-io/nex/internal/node.(*WorkloadManager).agentHandshakeSucceeded(0x140008bac30, {0x140006e2930, 0x24})
	/Users/runner/work/nex/nex/internal/node/workload_mgr.go:521 +0xa8

@jordan-rash saw this yesterday, also on macos. Taking a look at this...

I assumed it was my mac as i havent used it in a long while....guess it wasn't 🙍🏼‍♀️

@kthomas
Copy link
Contributor

kthomas commented Aug 1, 2024

This PR looks great.

It would make a lot of sense to keep JIT provisioning support, but make it conditional by creating a jit_provisioning flag in the node host services config (defaulting to true).

kthomas
kthomas previously approved these changes Aug 1, 2024
@autodidaddict autodidaddict requested a review from kthomas August 1, 2024 17:03
@autodidaddict autodidaddict merged commit 8179ba8 into main Aug 1, 2024
5 checks passed
@autodidaddict autodidaddict deleted the feat/hs_no_autoprovision branch August 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants