Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish function exec pass and fail cloud events with log emit #119

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

autodidaddict
Copy link
Contributor

No description provided.

@autodidaddict autodidaddict requested a review from a team as a code owner February 12, 2024 16:48
Copy link
Contributor

@kthomas kthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggerHandler should be an instance method on MachineManager and should probably be named handleTrigger to align with naming convention followed across other handlers.

@autodidaddict
Copy link
Contributor Author

triggerHandler should be an instance method on MachineManager and should probably be named handleTrigger to align with naming convention followed across other handlers.

Ok i'll make it an instance method. I go back and forth on naming conventions for funcs that return functions... I'll see what I can come up with.

@kthomas
Copy link
Contributor

kthomas commented Feb 14, 2024

There is one inconsistency in naming still between publishFunctionExecSucceeded and publishFuncExecFailed. Otherwise LGTM.

@autodidaddict autodidaddict merged commit b1df720 into main Feb 14, 2024
3 checks passed
@autodidaddict autodidaddict deleted the feat/funcexecutedevents branch February 14, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants