Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiveComponent] Use TypeInfo Type #2607

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Feb 26, 2025

Q A
Bug fix? no
New feature? no
Issues Fix #1708
License MIT

Replace PropertyInfo\Type by TypeInfo\Type and PropertyTypeExtractorInterface by TypeResolverInterface.
Also simplify a bit LivePropMetadata as Type already holds everything we need.

@mtarld mtarld force-pushed the feat/type-info-type branch 3 times, most recently from 87a72aa to d3edb38 Compare February 26, 2025 17:16
@mtarld
Copy link
Contributor Author

mtarld commented Feb 26, 2025

Actually, didn't notice that PHP 8.1 is still supported by Symfony UX.
Unfortunately, it'll prevent symfony/type-info to be installed in that version.

@mtarld mtarld force-pushed the feat/type-info-type branch 2 times, most recently from f3ada12 to 8777e0e Compare February 26, 2025 17:36
@mtarld mtarld force-pushed the feat/type-info-type branch from 8777e0e to 81650fd Compare February 26, 2025 17:36
@@ -29,7 +29,9 @@
"php": ">=8.1",
"symfony/deprecation-contracts": "^2.5|^3.0",
"symfony/property-access": "^5.4.5|^6.0|^7.0",
"symfony/property-info": "^5.4|^6.0|^7.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is a hard dependency, so it has to be moved to the require section.

@Kocal Kocal added this to the 3.x milestone Feb 26, 2025
@mtarld
Copy link
Contributor Author

mtarld commented Feb 26, 2025

Anyway, I think we must wait for the bump of PHP in composer.json (ie: symfony/ux-live-component:^3.0).

@Kocal
Copy link
Member

Kocal commented Feb 26, 2025

Added milestone 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LiveComponent] Transition to TypeInfo (fix 7.1 deprecations)
3 participants