feat: added general util functions with unit tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucad70
changed the title
storopoli
requested changes
Feb 21, 2025
backend/src/util.rs
Outdated
Comment on lines
42
to
62
| #[test] | ||
| fn test_convert_days_to_blocks() { | ||
| assert_eq!(convert_days_to_blocks(1), 144); | ||
| assert_eq!(convert_days_to_blocks(2), 288); | ||
| assert_eq!(convert_days_to_blocks(3), 432); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_check_npub() { | ||
| let npub = "npub1tv7hxxwtw4gcz4n6fpduads7lsmynh5pjedgfhvdctnulrz9rsksjx28xe"; | ||
| assert!(check_npub(npub.to_string())); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_nsec_to_hex() { | ||
| let nsec = "nsec1ezmlpxvhhjnqt9wf60tmshkye7xlwsf37dl0qlmrjuxeq7p3zahs2tukgx"; | ||
| let expected_hex = "c8b7f09997bca60595c9d3d7b85ec4cf8df74131f37ef07f63970d907831176f"; | ||
|
|
||
| let hex = convert_nsec_to_hex(nsec.to_string()); | ||
| assert_eq!(expected_hex, hex); | ||
| } |
There was a problem hiding this comment.
We are missing a test of the convert_nsec_to_secret_key. This is important to check if the conversion is successful and also should test if the SecretKey generated is valid.
There was a problem hiding this comment.
The function already uses the conversion before converting to hex, so the '''SecretKey::from_slice(&data)''' already does the check for a valid secret key.
storopoli
reviewed
Feb 21, 2025
storopoli
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented these basic functions for a Nostr and Segwit usage on interface
External:
convert_npub_to_public_key(npub: String) -> String (Uses bitcoin::key::PublicKey)
check_npub(npub: String) -> bool
Internal:
convert_nsec_to_secret_key (nsec: String) -> SecretKey (Uses bitcoin::key::SecretKey)