Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name of the Cache health result store parameter #68

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Fix name of the Cache health result store parameter #68

merged 1 commit into from
Feb 20, 2022

Conversation

andrzejkupczyk
Copy link
Contributor

@andrzejkupczyk andrzejkupczyk commented Feb 3, 2022 •
edited
Loading

The CacheHealthResultStore expects parameter named cacheStore, not store. For this reason, changing file to a different store did not affect the default configuration.

I had to find out why this results store is not working as expected... Hope this fix helps others save some time 😉

freekmurze
freekmurze requested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but let's solve it differently.

@freekmurze freekmurze merged commit f02b81e into spatie:main Feb 20, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze Awaiting requested review from freekmurze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrzejkupczyk @freekmurze