Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CarbonInterface to account for CarbonImmutable #35

Merged
merged 1 commit into from
Dec 25, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Checks/Result.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Spatie\Health\Checks;

use Carbon\Carbon;
use Carbon\CarbonInterface;
use Illuminate\Support\Str;
use Spatie\Health\Enums\Status;
use function trans;
Expand All @@ -12,7 +12,7 @@ class Result
/** @var array<string, string|int|bool> */
public array $meta = [];
public Check $check;
public ?Carbon $ended_at;
public ?CarbonInterface $ended_at;

public static function make(string $message = ''): self
{
Expand Down Expand Up @@ -96,7 +96,7 @@ public function meta(array $meta): self
return $this;
}

public function endedAt(Carbon $carbon): self
public function endedAt(CarbonInterface $carbon): self
{
$this->ended_at = $carbon;

Expand Down