Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow declaring custom or multiple notification classes in health.php #200

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Allow declaring custom or multiple notification classes in health.php #200

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e98d03
Allow declaring custom or multiple notification classes in health.php
christosku Oct 25, 2023
6595121
Only return the first notification class from health.php
christosku Oct 30, 2023
a90bc85
Fix styling
christosku Oct 31, 2023
52a8ea4
Use array_key_first to get the first key in the notifications array
christosku Nov 1, 2023
977a979
Merge from main
christosku Nov 1, 2023
c5e20de
Fix styling
christosku Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Commands/RunHealthChecksCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
use Spatie\Health\Events\CheckStartingEvent;
use Spatie\Health\Exceptions\CheckDidNotComplete;
use Spatie\Health\Health;
use Spatie\Health\Notifications\CheckFailedNotification;
use Spatie\Health\ResultStores\ResultStore;

class RunHealthChecksCommand extends Command
Expand Down Expand Up @@ -162,10 +161,10 @@ protected function determineCommandResult(Collection $results): int
}

/**
* @return class-string<CheckFailedNotification>
* @return class-string
*/
protected function getFailedNotificationClass(): string
{
return CheckFailedNotification::class;
return array_key_first(config('health.notifications.notifications'));
}
}