-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom HealthCheckResultHistoryItem models #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think there could be an issue when you want to use multiple stores, but I guess not too many people will do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback 😊 Just made the changes, and PhpStan seems happy now — let me know if you'd like any other tweaks. 👌
Thanks! |
As discussed in #16 — this PR implements a
model
config parameter, for use by theEloquentHealthResultStore
class.I followed the general conventions used by http://github.com/spatie/laravel-activitylog for setting custom models — hopefully that's along the right lines this time.
This PR is backwards-compatible.
Thanks! 🙌