Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom HealthCheckResultHistoryItem models #18

Merged
merged 13 commits into from
Dec 14, 2021

Conversation

jackwh
Copy link
Contributor

@jackwh jackwh commented Dec 13, 2021

As discussed in #16 — this PR implements a model config parameter, for use by the EloquentHealthResultStore class.

I followed the general conventions used by http://github.com/spatie/laravel-activitylog for setting custom models — hopefully that's along the right lines this time.

This PR is backwards-compatible.

Thanks! 🙌

Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think there could be an issue when you want to use multiple stores, but I guess not too many people will do that.

Copy link
Contributor Author

@jackwh jackwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback 😊 Just made the changes, and PhpStan seems happy now — let me know if you'd like any other tweaks. 👌

@jackwh jackwh requested a review from freekmurze December 13, 2021 19:38
@freekmurze freekmurze merged commit d193f2e into spatie:main Dec 14, 2021
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants