Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store skipped checks results #120

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Fix store skipped checks results #120

merged 3 commits into from
Sep 13, 2022

Conversation

patrick-levesque
Copy link
Contributor

This PR fixes an issue with storing results using EloquentHealthResultStore for skipped checks when a frequency method such as ->everyFiveMinutes() is used. The ended_at field is required and was not set for skipped checks. Also added ResultStores tests for skipped checks.

@freekmurze
Copy link
Member

Thanks! Could you take a look at the failing tests?

@patrick-levesque
Copy link
Contributor Author

"But it works on my computer." 😂 All tests pass locally and I didn't modify this failing test. After checking, I think it is possible that DatabaseConnectionCountCheckTest only gets 1 connection which fails the expect($result->getNotificationMessage()) contains connections (plural). I will update this test to expect only connection and it should avoid this issue.

@patrick-levesque
Copy link
Contributor Author

I had to merge recent commits with Capitalize short summary for PingCheck to get all tests pass. 😅

@freekmurze freekmurze merged commit b8daad9 into spatie:main Sep 13, 2022
@freekmurze
Copy link
Member

Thanks!

@patrick-levesque patrick-levesque deleted the store-skipped-checks-fix branch September 13, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants