Make histogram interactive in DomainSlider #1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That could have been as simple as adding this line.
But due to airbnb/visx#1174, the point positions when dragging are wrongly computed as the domain slider root div is translated via
transform
. The purpose of thetransform
was to center the tooltip with respect to the slider.Therefore, I reimplemented the centering by adding a flex container around the slider container and the tooltip to center them. This allows to remove
transform
from the histogram hierarchy of parents to work around airbnb/visx#1174.