Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable width faces support #301

Closed
Vincent-P opened this issue Feb 10, 2020 · 10 comments
Closed

Variable width faces support #301

Vincent-P opened this issue Feb 10, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@Vincent-P
Copy link

Is your feature request related to a problem? Please describe.
I really enjoy having variable-width fonts for every UI fonts, but I can't do this with doom-modeline.
If for example I set doom-modeline-buffer-path or doom-modeline-buffer-file face family to "Noto Sans" with this: (set-face-attribute 'doom-modeline-buffer-path nil :family "Noto Sans"), the buffer in inactives modelines will still be displayed using a fixed-width font.

Describe the solution you'd like
Is it possible to have inactive variant for each face? Maybe there is an even better solution?

Describe alternatives you've considered
Well there isn't any alternative so I am stuck with fixed-width font for now...

Additional context
image

@seagle0128
Copy link
Owner

You may need to change the faces of mode-line and mode-line-inactive, but the icons may be not displayed corrected.

@Vincent-P
Copy link
Author

Yes it breaks the icon font that's why I didnt mention it.

@seagle0128 seagle0128 added the enhancement New feature or request label Feb 11, 2020
@Vincent-P
Copy link
Author

I am going to try thanks!

@seagle0128
Copy link
Owner

I committed a patch to support different fonts in mode line. Just need to set mode-line and mode-line-inactive face. All icons should be Okay now. The right position of the segment may not be accurate but I think it's a minor issue.

@Vincent-P
Copy link
Author

Vincent-P commented Feb 11, 2020

Now I have this issue: #300, not necessarily in org mode.

@seagle0128
Copy link
Owner

Are you using doom?

@Vincent-P
Copy link
Author

No.
I added this to my config:

  (set-face-attribute 'mode-line nil :family "Noto Sans")
  (set-face-attribute 'mode-line-inactive nil :family "Noto Sans")

The mode indicator in the inactive mode-line is a weird character instead of an icon, it also happens with other fonts.

seagle0128 added a commit that referenced this issue Feb 12, 2020
See #301.
To display the icons in inactive windows correctly.
@seagle0128
Copy link
Owner

A new face doom-modeline-icon-inactive is introduced. Hope all icons can be displayed correctly now.

@Vincent-P
Copy link
Author

It's perfect now thanks a lot! :)

@seagle0128
Copy link
Owner

@Vincent-P Great! Can you please help to test with the default font as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants