Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Event management & colors #439

Merged
merged 7 commits into from
Apr 25, 2023
Merged

refactor: Event management & colors #439

merged 7 commits into from
Apr 25, 2023

Conversation

gouz
Copy link
Collaborator

@gouz gouz commented Apr 24, 2023

I refactor the events management. Instead of passing the event into each days, I create a global window object window.events structured like this:

{ year : { month : { day : [events] } } }

As example:

{ '2024' : { '1' : { '2' : [{event1}, {event2}] } } }

I add the navigation system too:

image

close #339
&
close #424

@gouz gouz marked this pull request as draft April 25, 2023 07:37
@gouz gouz marked this pull request as ready for review April 25, 2023 08:00
@gouz gouz changed the title fix: #339 refactor: Event management & colors Apr 25, 2023
@scraly
Copy link
Owner

scraly commented Apr 25, 2023

Suggestion: use the existing back and next buttons
Bug: the scrollTo feature is not working at the first click on a day

Copy link
Owner

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants