Build and test on arm64 runner #4802
Conversation
harryzcy
force-pushed
the
build-arm64
branch
from
b6213fe to
59dd43f
Compare
|
@aairey should we merge this, despite multiple failures? |
I don't think so. Someone who understands these test failures should take a look. |
in that case, what was the purpose of approving this pr? |
There was a problem hiding this comment.
separately, since you seem to understand about docker so much, could you help make sense of the claim that docker images no longer work, please?
see context: #4761 (comment)
| @@ -21,6 +21,7 @@ jobs: | |||
| os: | |||
| - windows-latest | |||
| - ubuntu-latest | |||
| - ubuntu-24.04-arm | |||
There was a problem hiding this comment.
i am not sure about this... we don't run on macos either.
There was a problem hiding this comment.
hmm... now i wonder why tests have failed for this platform. any ideas?
| @@ -54,7 +55,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| java: [ '11' ] | |||
| os: [ windows-latest, ubuntu-latest ] | |||
| os: [ windows-latest, ubuntu-latest, ubuntu-24.04-arm ] | |||
There was a problem hiding this comment.
we definitely don't need this, the whole point was to make sure windows and non-windows are handled correctly.
| @@ -61,20 +61,17 @@ jobs: | |||
| dockerize: | |||
| needs: [ scala-native ] | |||
| if: ${{ github.event_name == 'release' == success() }} | |||
| runs-on: ubuntu-latest | |||
| runs-on: ${{ matrix.platform == 'linux/arm64' && 'ubuntu-24.04-arm' || 'ubuntu-latest' }} | |||
There was a problem hiding this comment.
not ubuntu-latest anymore, it's a fixed version now.
also, any way to re-use the same deploy matrix (with os and name fields) from above?
| @@ -83,12 +80,59 @@ jobs: | |||
| with: | |||
| username: ${{ secrets.DOCKER_USERNAME }} | |||
| password: ${{ secrets.DOCKER_PASSWORD }} | |||
| - name: Set up Docker Buildx | |||
| uses: docker/setup-buildx-action@v3 | |||
| push: true | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| outputs: type=image,"name=scalameta/scalafmt",push-by-digest=true,name-canonical=true |
There was a problem hiding this comment.
why do we not need tags here?
| - name: Upload digest | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: digests-${{ matrix.platform == 'linux/arm64' && 'arm64' || 'amd64' }} |
There was a problem hiding this comment.
this test keeps getting repeated. i'd go with the same, or similar, multi-field matrix strategy (see comment above, about deploy matrix).
linux/arm64docker imagesCloses #3542