Enable setting default profile by env variable #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Johnabell thanks for the PR i'll review it tomorrow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #996 +/- ##
==========================================
+ Coverage 92.84% 92.92% +0.07%
==========================================
Files 118 118
Lines 23827 23755 -72
==========================================
- Hits 22123 22075 -48
+ Misses 1704 1680 -24 ☔ View full report in Codecov by Sentry. |
sagiegurari
reviewed
Dec 15, 2023
| @@ -2662,6 +2662,10 @@ command = "echo" | |||
| args = [ "running in production profile" ] | |||
| ``` | |||
|
|
|||
| #### Default profile | |||
There was a problem hiding this comment.
can you put this in the content.md instead of readme as readme is generated?
also please add an anchor like link above and a link to this anchor in nav.md
|
@Johnabell this is great thanks. just 1 minor comment regarding the documentation going into the wrong file. |
|
@Johnabell decided to fix the docs for you... thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to be able to set a default profile by env variable. This will help to have a different profile as default when, for example, working in a docker container vs working on the host machine.
This PR add the support for this allowing users to set
CARGO_MAKE_DEFAULT_PROFILEso all future invocations ofcargo makewill use the given profile. If this variable is not set, it will fall back to the current behaviour of usingdevelopmentas the default profile.