Prevent wasteful busy cpu spinning #1045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I'd like to say a huge thankyou for your work on cargo-make, it's replaced all of my previous make workflows!
Now, this pull request may seem rediculous, however the unstable ctrl-c implementation in it's current form
will busy loop a whole cpu core while it's running, impacting performance, battery life, etc.
There's probably a better way to approach this, but as a simple fix I have added a minimal sleep to the loop.
Happy to sign away any rights to the provided code, etc.